Behdad Esfahbod's daily notes on GNOME, Pango, Fedora, Persian Computing, Bob Dylan, and Dan Bern!

My Photo
Name:
Location: Toronto, Ontario, Canada

Ask Google.

Contact info
Google
Hacker Emblem Become a Friend of GNOME I Power Blogger
follow me on Twitter
Archives
July 2003
August 2003
October 2003
November 2003
December 2003
March 2004
April 2004
May 2004
July 2004
August 2004
September 2004
November 2004
March 2005
April 2005
May 2005
June 2005
July 2005
August 2005
September 2005
October 2005
November 2005
December 2005
January 2006
February 2006
March 2006
April 2006
May 2006
June 2006
July 2006
August 2006
September 2006
October 2006
November 2006
December 2006
January 2007
February 2007
March 2007
April 2007
May 2007
June 2007
July 2007
August 2007
September 2007
October 2007
November 2007
December 2007
January 2008
February 2008
March 2008
April 2008
May 2008
June 2008
July 2008
August 2008
October 2008
November 2008
December 2008
January 2009
March 2009
April 2009
May 2009
June 2009
July 2009
August 2009
November 2009
December 2009
March 2010
April 2010
May 2010
June 2010
July 2010
October 2010
November 2010
April 2011
May 2011
August 2011
September 2011
October 2011
November 2011
November 2012
June 2013
January 2014
May 2015
Current Posts
McEs, A Hacker Life
Tuesday, June 19, 2007
 JDS Patch Review

(Note: After receiving two comments and rereading my previous post, I removed it in accordance to CoC which I have volunteerly signed. Well, we're cool now.)

Seeing people commenting on JDS patches for their packages, I couldn't help but checking pango, cairo, and vte patches they ship. Having reviewed them, I thought I should provide some feedback :). I'm posting here, hoping that other GNOME hackers pick this up too. Later we can move on to collectively review other vendors' patches too, and help the over-busy maintainers push the right patches upstream and drop/fix the wrong ones. Not every project has a sebuild, right? ;) Brian Cameron has been doing a great job doing that for opensolaris already, but there's more room.
All in all, very good for cairo, but can do better for vte and pango.

Labels: , , ,

Comments:
The -uninstalled files were invented for "gtk+-enterprise-edition" which was a big tarball containing gtk and all dependencies created for reasons that I don't really remember.

To build the tarball, you had to be able to run make from the toplevel and build all the subdirectories (glib, pango, gtk, etc.), without a make install on each dependency as you went.

It was very hard to maintain a build that worked right in this giant tarball context, but the uninstalled .pc files were part of what you had to do.
 
http://live.gnome.org/VendorPatches has links to a whole bunch of vendor patches.
 
I'll take a bow any day for a man that is capable of admitting he was wrong, so my hat's off to you Behdad!

And a good thing to see you turned that energy elsewhere and reviewed patches like a madman instead ;)

Keep up the good work!

/A humble admirer
 
In Sun we use uninstalled pc because we often group multiple dependant modules in one package and don't install the package until all modules are built.
For example, if SUNWmeta-pkg has modules A, B and C.
The build sequence is:
* A.prep
* B.prep
* C.prep
* A.build (configure; make)
* B.build
* C.build
* A.install (make install to $RPM_BUILD_ROOT)
* B.install
* C.install
* Generate package.
* Install package

If module B or C needs uses pkg-config to reference module A, an uninstalled.pc file is used.

Does this help explain why patches like cairo-01-uninstalled-pc.diff exist?
 
Feel free to review the patches in the pango1.0 and vte packages maintained by the Debian GNOME Team! :)

Currently, the latest versions of these can be found at:
desktop/experimental/pango1.0/debian/patches
desktop/unstable/vte/debian/patches

I've updated the VendorPatches page with more complete and recent information.

We're in the process of slowly integrating bug references and descriptions at the top of patches, but not all patches carry such information yet.
 
vte-03-cut-copy-paste-handle.diff says "Bind Copy, Paste, Cut keys". It seems to bind F16, F18, and F20 (GDK_F16, etc.) keys to signals "copy-clipboard" and "paste-clipboard".

I guess "cut" makes little sense for a terminal widget (that's what VTE is, right?), so the key marked "cut" generates "copy", as well.

Sun people have always had weird keyboards. :-)
 
This is Brian Cameron (Brian.Cameron@sun.com). Thanks for the nice comment.

Here is some feedback and bugzilla bug numbers.

The pango-01-fullspace.diff patch is in bugzilla bug 145275. Note the older patch which is sort of like the patch we apply here at Sun. If there's a better way to fix, this then let me know and I'll be happy to update our patch.

The pango-03-no-xrender.diff patch is because the Sun Xserver team doesn't yet ship the pc files. They are slowly fixing this, and we'll remove this patch once the pc file is in Solaris.

I think that the cairo uninstalled pc patch has been discussed well enough. Most GNOME modules that provide libraries provide this file to make building possible when dependent modules are not yet installed. Our build process here at Sun depends on this feature.

The vte-01-fcconfig.diff is bugzilla 142640. vte-03-cut-copy-paste.diff is bugzilla 153265. vte-04-selection-perf-improve is bugzilla 143914.
 
Post a Comment

Links to this post:

Create a Link



<< Archive
<< Home